bpo-40645: restrict HMAC key len to INT_MAX #20238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heimes <[email protected]>
vstinner
reviewed
May 19, 2020
| @@ -1403,6 +1403,12 @@ _hashlib_hmac_new_impl(PyObject *module, Py_buffer *key, PyObject *msg_obj, | |||
| HMACobject *self = NULL; | |||
| int r; | |||
|
|
|||
| if (key->len > INT_MAX) { | |||
| PyErr_SetString(PyExc_OverflowError, | |||
| "key is too long."); | |||
There was a problem hiding this comment.
"2 GB key should be enough for everyone" :-D
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-20245 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2020
Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran (cherry picked from commit aca4670) Co-authored-by: Christian Heimes <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 19, 2020
Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran (cherry picked from commit aca4670) Co-authored-by: Christian Heimes <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue40645
Automerge-Triggered-By: @tiran