bpo-30594: Add a test for bad IDNA in ssl server_hostname #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njsmith
force-pushed
the
make-victor-happy
branch
from
820c462 to
f3c34f1
Compare
serhiy-storchaka
approved these changes
Jun 8, 2017
serhiy-storchaka
changed the title
vstinner
reviewed
Jun 8, 2017
Lib/test/test_ssl.py
Outdated
| ctx = ssl.create_default_context() | ||
| # Do it a few times, because this used to cause memory corruption | ||
| # https://bugs.python.org/issue30594 | ||
| for _ in range(5): |
There was a problem hiding this comment.
I don't think that it's worth it to run it in a loop. Just run it once. It's only a regression test. We have enough buildbots to catch race conditions if there is a test ;-)
vstinner
reviewed
Jun 8, 2017
Lib/test/test_ssl.py
Outdated
| # free to remove it. | ||
| ctx = ssl.create_default_context() | ||
| # Do it a few times, because this used to cause memory corruption | ||
| # https://bugs.python.org/issue30594 |
There was a problem hiding this comment.
Usually, we just write "# bpo-30594: ..."
njsmith
force-pushed
the
make-victor-happy
branch
from
f3c34f1 to
93f1659
Compare
njsmith
force-pushed
the
make-victor-happy
branch
from
93f1659 to
a30411e
Compare
|
Comments addressed. |
|
Thanks @njsmith for the unit test! I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion:
#1992 (comment)