Skip to content

bpo-30584: Fix test_os fails on non-English Windows #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2017
Merged

bpo-30584: Fix test_os fails on non-English Windows #1980

merged 3 commits into from
Jun 7, 2017

Conversation

denis-osipov
Copy link
Contributor

On Microsoft Support page Well-known security identifiers in Windows operating systems said:

A security identifier (SID) is a unique value of variable length that is used to identify a security principal or security group in Windows operating systems. Well-known SIDs are a group of SIDs that identify generic users or generic groups. Their values remain constant across all operating systems.

So I suggest to use SID (*S-1-5-32-545) instead of name (Users).

eryksun
eryksun reviewed Jun 7, 2017
View reviewed changes
Lib/test/test_os.py Outdated
@@ -472,7 +472,7 @@ def test_access_denied(self):
# force CreateFile to fail with ERROR_ACCESS_DENIED.
DETACHED_PROCESS = 8
subprocess.check_call(
['icacls.exe', fname, '/deny', 'Users:(S)'],
['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
Copy link
Contributor

@eryksun eryksun Jun 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using the numeric SID to avoid localized names is correct. Thanks for catching this.

vstinner
vstinner reviewed Jun 7, 2017
View reviewed changes
Lib/test/test_os.py Outdated
@@ -472,7 +472,7 @@ def test_access_denied(self):
# force CreateFile to fail with ERROR_ACCESS_DENIED.
DETACHED_PROCESS = 8
subprocess.check_call(
['icacls.exe', fname, '/deny', 'Users:(S)'],
['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment mentionning the bpo and explaining what is this identifier, like:

# bpo-30584: Use security identifier *S-1-5-32-545 instead of localized "Users"
# to not depend on the locale

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

vstinner
vstinner reviewed Jun 7, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's your first contribution. In that case, you should add yourself to Misc/ACKS please!

@vstinner vstinner merged commit 897bba7 into python:master Jun 7, 2017
@denis-osipov denis-osipov deleted the fix-issue-30584 branch June 7, 2017 17:25
@denis-osipov denis-osipov restored the fix-issue-30584 branch June 7, 2017 17:25
@denis-osipov denis-osipov deleted the fix-issue-30584 branch June 7, 2017 17:27
vstinner pushed a commit that referenced this pull request Jun 8, 2017
@denis-osipov @vstinner
[3.6] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#…
ca1b66f 
…1999)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
(cherry picked from commit 897bba7)
vstinner pushed a commit that referenced this pull request Jun 8, 2017
@denis-osipov @vstinner
[3.5] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#…
a0b9088 
…2000)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
(cherry picked from commit 897bba7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@eryksun eryksun eryksun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denis-osipov @vstinner @eryksun @the-knights-who-say-ni