[3.6] bpo-29822: make inspect.isabstract() work during __init_subclass__ #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2017 17:16
…s__. (pythonGH-678) At the time when an abstract base class' __init_subclass__ runs, ABCMeta.__new__ has not yet finished running, so in the presence of __init_subclass__, inspect.isabstract() can no longer depend only on TPFLAGS_IS_ABSTRACT.. (cherry picked from commit fcfe80e)
This PR was generated by cherry_picker.py. There was a merge conflict in Misc/NEWS that I thought I resolved correctly, but the diff of this branch with master shows that the news item is new-to-this-PR. I'm not sure what's going on, but this commit removes the news item. I'd appreciate a second pair of eyes making sure that I'm doing things right.
The cherry-pick apparently introduced a duplicate item in Misc/NEWS, not sure exactly how. The previous commit removed one copy, but I accidentally removed the spurious copy. I *think* this commit will set things right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #678 to python 3.6. It depends on #527, which was only recently backported (#1282), and I might have made this backport too soon, in which case I apologized.
Also, I'm not entirely sure that I used the cherry picker tool correctly, because (e.g) a new news item snuck into Misc/NEWS when the backport was generated; I'll clean that up shortly, but I recommend having someone double-check that I'm doing this right :-)