Skip to content

bpo-30557: Fix test_faulthandler #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

bpo-30557: Fix test_faulthandler #1969

merged 1 commit into from
Jun 6, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 6, 2017

On Windows 8, 8.1 and 10 at least, the exit code is the exception
code (no bit is cleared).

On Windows 8, 8.1 and 10 at least, the exit code is the exception
code (no bit is cleared).
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zooba zooba merged commit 6a1d84e into python:master Jun 6, 2017
@zooba
Copy link
Member

zooba commented Jun 6, 2017

I cherry picked this into my backport PR, which hasn't merged yet.

zooba pushed a commit to zooba/cpython that referenced this pull request Jun 6, 2017
On Windows 8, 8.1 and 10 at least, the exit code is the exception
code (no bit is cleared).
@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2017 via email

zooba added a commit that referenced this pull request Jun 6, 2017
…ption … (#1960)

* bpo-30557: faulthandler now correctly filters and displays exception codes on Windows (#1924)

* bpo-30557: faulthandler now correctly filters and displays exception codes on Windows

* Adds test for non-fatal exceptions.

* Adds bpo number to comment.

* bpo-30557: Fix test_faulthandler (#1969)

On Windows 8, 8.1 and 10 at least, the exit code is the exception
code (no bit is cleared).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants