Skip to content

bpo-30524: Fix _PyStack_UnpackDict() #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2017
Merged

bpo-30524: Fix _PyStack_UnpackDict() #1886

merged 1 commit into from
Jun 9, 2017

Conversation

vstinner
Copy link
Member

  • bpo-29259: Remove unused func parameter of _PyStack_UnpackDict()
  • bpo-29286: Change _PyStack_UnpackDict() prototype to be able to
    notify of failure when args is NULL. _PyStack_UnpackDict() now
    returns -1 on error.

@vstinner
bpo-30524: Fix _PyStack_UnpackDict()
18d79b3 
* bpo-29259: Remove unused func parameter of _PyStack_UnpackDict()
* bpo-29286: Change _PyStack_UnpackDict() prototype to be able to
  notify of failure when args is NULL. _PyStack_UnpackDict() now
  returns -1 on error.
serhiy-storchaka
serhiy-storchaka approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But would be nice to add a test.

@vstinner
Copy link
Member Author

vstinner commented Jun 9, 2017

LGTM. But would be nice to add a test.

I wrote unit tests for FASTCALL including a specific unit test for the datetime.datetime.now() specific case: #2022

The PR was written for master, but I will then backport it to Python 3.6.

@vstinner vstinner merged commit f0ff849 into python:3.6 Jun 9, 2017
@vstinner vstinner deleted the unpack_dict branch June 9, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @methane @serhiy-storchaka @the-knights-who-say-ni