Skip to content

[3.7] bpo-37953: Fix ForwardRef hash and equality checks (GH-15400) #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[3.7] bpo-37953: Fix ForwardRef hash and equality checks (GH-15400) #18751

merged 1 commit into from
Mar 3, 2020

Conversation

rfrowe
Copy link

@rfrowe rfrowe commented Mar 2, 2020

Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again.

https://bugs.python.org/issue37953
(cherry picked from commit e082e7c)

Co-authored-by: plokmijnuhby [email protected]

https://bugs.python.org/issue37953

Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again.

https://bugs.python.org/issue37953
(cherry picked from commit e082e7c)

Co-authored-by: plokmijnuhby <[email protected]>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement labels Mar 2, 2020
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rfrowe

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fine backport. Still, I'd like to see the CLA signed before landing.

@rfrowe
Copy link
Author

rfrowe commented Mar 2, 2020

I signed immediately after the bot commented. Now waiting the required one business day for it to be picked up by the system as my user still doesn't show in check-python-cla

@rfrowe
Copy link
Author

rfrowe commented Mar 2, 2020

Hoping to get this in before 3.7.7rc1 is tagged though (which is soon according to PEP 537)

@gvanrossum
Copy link
Member

@rfrowe Thanks for the little push!

@rfrowe rfrowe deleted the backport-e082e7c-3.7 branch March 4, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants