-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[3.6] Change six instances of "an" to "a" #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"An ModuleNotFoundError" appears several times in this document, likely because in the previous version it used to be "An ImportError". "An path" also appears. These instances of "an" should be "a" instead.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Initially I wasn't sure whether "an
Besides path, all of the other "an"s here precede a name starting with a vowel. |
@kms70847 is this purposefully only against 3.6 and not master? Is master fixed for this? |
The changes here should be applied to |
This looks okay to me. The ModuleNotFoundError change was introduced with commit 46f97b8. For bonus points, the problem with an could also be fixed in a comment in “test.test_importlib.import_.test_fromlist.HandlingFromlist.test_module_from_package_triggers_ModuleNotFoundError”. |
I tried changing the base to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the change against master branch.
"An ModuleNotFoundError" appears several times in this document, likely because in the previous version it used to be "An ImportError". "An path" also appears. These instances of "an" should be "a" instead. (Second attempt at this pull request; python#1814 was on the wrong branch)
I have created a new pull request with identical changes except it's on the master branch: #1862 I could not quite figure out how to change the branch without creating a new PR. I apologize if this is an inconvenience. |
"An ModuleNotFoundError" appears several times in this document, likely because in the previous version it used to be "An ImportError".
"An path" also appears.
These instances of "an" should be "a" instead.