-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-75666: Fix Misc.unbind behaviour when funcid is given #17954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allows Misc.unbind to delete only the bound callback having the given funcid. See the issue above for more.
bpo-31485: Fix Misc.unbind behaviour when funcid is given
About the ubuntu test failure: it happens at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a new test is needed to verify that the revision does what we want and expect it to.
Misc/NEWS.d/next/Library/2020-01-11-22-09-29.bpo-31485.DSvjsY.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Fix `_tkinter.TclError: can't delete Tcl command` on Ubuntu bionic. Change `bound` to `keep` as suggested.
Revise docstring to match behavior specified by Serhiy. Rearrange code to match.
The Travis failure is bogus as far as this issue is concerned: 1. a warning about a future docutils change, treated as an error; 2. news.gmane.io not responding. The Travis code tests (Ubuntu) passed. @serhiy-storchaka Do you want to add tests for this? On this issue? There seem to be no existing bind tests. ('bind' only occurs, 8 times, in test_ttk.test_widgets.) It would seem that Misc._bind could also stand being tested. I think the code is ready to merge, pending your review. |
Oh, yes, such non-trivial code needs tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me, but it would be nice to add tests.
@@ -0,0 +1 @@ | |||
https://github.com/python/cpython/pull/17954# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a short description, not a link.
There will be a link to the corresponded issue on the tracker in any case.
Uh oh!
There was an error while loading. Please reload this page.