Skip to content

Simplify control flow when exiting the interpreter. #17756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

markshannon
Copy link
Member

Skip the stack emptying step for RETURN_VALUE, as the compiler now ensures that the stack is empty.

Remove test that generates invalid bytecode.
Maybe we should have a bytecode verifier, but that's not the job of the interpreter.

No change in behaviour, so no news or BPO issue needed.

@pablogsal
Copy link
Member

as the compiler now ensures that the stack is empty

Out of curiosity, in which PR/issue was this changed?

@markshannon
Copy link
Member Author

#6641

@pablogsal
Copy link
Member

#6641

Thanks, Mark!

@markshannon markshannon merged commit e7c9f4a into python:master Jan 13, 2020
@markshannon markshannon deleted the cleanup-interpreter-exit branch January 13, 2020 12:51
sthagen added a commit to sthagen/python-cpython that referenced this pull request Jan 13, 2020
Cleanup exit code for interpreter. (pythonGH-17756)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants