Skip to content

bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT #17231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT #17231

merged 1 commit into from
Nov 20, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 18, 2019 •
edited by bedevere-bot
Loading

PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they
do nothing for one year (since commit
735ae8d), stop using them.

https://bugs.python.org/issue38835

pablogsal
pablogsal approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I also double-checked that after this PR there are no usages of the macro left.

One question and a minor code suggestion for the NEWS file:

Do you want to left the empty macro in Include/pyfpe.h?

@pablogsal
Copy link
Member

We don't provide any contract regarding these macros and I don't see a way a user can override them easily so I don't think we should be concerned with that.

@vstinner
Copy link
Member Author

Do you want to left the empty macro in Include/pyfpe.h?

If someone wants to remove them, I would suggest to first deprecate them, and wait at least one Python release before removing them. And do that in a separated issue: https://bugs.python.org/issue38835 title is "pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API", it's not directly related :-)

@vstinner
bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT
a467fd7 
The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty:
they have been doing nothing for the last year  (since commit
735ae8d), so stop using them.
@vstinner
Copy link
Member Author

I updated the NEWS entry.

I rebased the PR to be able to modify the commit message (copy of the NEWS entry).

@vstinner
Copy link
Member Author

We don't provide any contract regarding these macros and I don't see a way a user can override them easily so I don't think we should be concerned with that.

I think the only way to get non-empty macros is to modify pyfpe.h. I doubt anyone does that.

@vstinner vstinner merged commit be143ec into python:master Nov 20, 2019
@vstinner vstinner deleted the remove_pyfpe branch November 20, 2019 01:51
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT (pytho…
f2bd268 
…nGH-17231)

The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty:
they have been doing nothing for the last year  (since commit
735ae8d), so stop using them.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT (pytho…
5de7993 
…nGH-17231)

The PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty:
they have been doing nothing for the last year  (since commit
735ae8d), so stop using them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@njsmith njsmith Awaiting requested review from njsmith

@mdickinson mdickinson Awaiting requested review from mdickinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot