bpo-30290: IDLE: Refactor help_about to PEP8 names #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @mlouielu to be potential reviewers. |
terryjreedy
approved these changes
May 27, 2017
| self.bind('<Return>',self.Ok) #dismiss dialog | ||
| self.bind('<Escape>',self.Ok) #dismiss dialog | ||
| self.button_ok.focus_set() | ||
| self.bind('<Return>', self.ok) # dismiss dialog |
There was a problem hiding this comment.
Yes, do correct spacing when we are otherwise editing a file. A file with no within-line spaces is harder to read.
|
Thanks! |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 10, 2017
Patch by Cheryl Sabella. (cherry picked from commit 5a346d5)
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 10, 2017
Patch by Cheryl Sabella. (cherry picked from commit 5a346d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.