Skip to content

bpo-38396: dump(node) instead of repr(node) on ast.literal_eval #16620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-38396: dump(node) instead of repr(node) on ast.literal_eval #16620

wants to merge 1 commit into from

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Oct 7, 2019 •
edited by bedevere-bot
Loading

vstinner
vstinner reviewed Dec 14, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to write a test?

@isidentical
Copy link
Member Author

isidentical commented Dec 14, 2019 •
edited by bedevere-bot
Loading

bpo-38396 resolved as duplicate of bpo-32888 and #340 is about fixing it. It has a slightly different approach but resolves the same problem so I think this PR can be closed.

@vstinner vstinner mentioned this pull request Dec 14, 2019
Closed
@vstinner
Copy link
Member

Oh, @ilevkivskyi seems to be against this PR, so I close it: https://bugs.python.org/issue38396#msg354132 I agree that PR #340 should produce shorter and better error message.

@vstinner vstinner closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isidentical @vstinner @the-knights-who-say-ni @bedevere-bot