bpo-38334: Fix seeking bug for encrypted zipfiles #16529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralises the logic for initialising the decompressor and decrypter when 1. opening the file and 2. seeking backwards in a file stream.
This commit resolves an issue where seeking on an encrypted zipfile would cause the crc keys to go out of sync resulting in data read after the seek to be garbled. This commit refactors `_ZipDecrypter` to be a class (`CRCZipDecrypter`) that can be reinitialised when seeking back to the beginning of a zipped file. In doing so, some of the logic relating to configuring the decrypter which was found in `ZipFile` has been moved to the decrypter class.
|
Fixed by #16937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where seeking on an encrypted
zipfilewould cause the crc keys to go out of sync resulting in bad data to be read after the seek.https://bugs.python.org/issue38334