Skip to content

bpo-38153: detect shake independently from sha3 (GH-16143) #16143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2019
Merged

bpo-38153: detect shake independently from sha3 (GH-16143) #16143

merged 1 commit into from
Sep 14, 2019
+11 −2

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 14, 2019 •
edited by bedevere-bot
Loading

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue38153

@tiran tiran changed the title bpo-38153: detect shake independently from sha3 bpo-38153: detect shake independently from sha3 (GH-16143) Sep 14, 2019
@tiran tiran merged commit eb2b0c6 into python:master Sep 14, 2019
@tiran tiran deleted the bpo-38153-2 branch September 14, 2019 15:29
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eb2b0c694aef6122fdf95015abb24e0d095b6401 3.8

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16179 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 16, 2019
@miss-islington @tiran
bpo-38153: detect shake independently from sha3 (GH-16143)
0067fc2 
XOF digests (SHAKE) are not available in OpenSSL 1.1.0 but SHA3 fixed-length digests are.

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit eb2b0c6)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tiran tiran

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @miss-islington @bedevere-bot @the-knights-who-say-ni