Skip to content

bpo-38059: Using sys.exit() over exit() in inspect.py #15666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2019
Merged

bpo-38059: Using sys.exit() over exit() in inspect.py #15666

merged 2 commits into from
Sep 9, 2019

Conversation

alanyee
Copy link
Contributor

@alanyee alanyee commented Sep 3, 2019

Constants added by the site module like exit() "should not be used in programs"
https://docs.python.org/3/library/constants.html#exit

https://bugs.python.org/issue38059

Constants added by the site module like exit() "should not be used in programs"
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

I understand that the change is arguably trivial... but given that this is a code change in a commonly-used module, do you mind creating an issue and NEWS entry for it?

@alanyee alanyee changed the title Using sys.exit() over exit() in inspect.py bpo-38059: Using sys.exit() over exit() in inspect.py Sep 8, 2019
@zooba
Copy link
Member

zooba commented Sep 9, 2019

Thanks for the PR!

@zooba zooba merged commit e3c59a7 into python:master Sep 9, 2019
@miss-islington
Copy link
Contributor

Thanks @alanyee for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs"
(cherry picked from commit e3c59a7)

Co-authored-by: Alan Yee <[email protected]>
@bedevere-bot
Copy link

GH-15783 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs"
(cherry picked from commit e3c59a7)

Co-authored-by: Alan Yee <[email protected]>
@bedevere-bot
Copy link

GH-15784 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs"
(cherry picked from commit e3c59a7)

Co-authored-by: Alan Yee <[email protected]>
miss-islington added a commit that referenced this pull request Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs"
(cherry picked from commit e3c59a7)

Co-authored-by: Alan Yee <[email protected]>
@alanyee alanyee deleted the patch-2 branch October 17, 2019 18:04
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Constants added by the site module like exit() "should not be used in programs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants