bpo-37953:Improve ForwardRef equality check #15650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can solve the recursion problem incidentally https://bugs.python.org/issue37806. I add some tests for that. |
aeros
reviewed
Sep 2, 2019
There was a problem hiding this comment.
Based on @ilevkivskyi's comment in the related PR:
Generally, I would propose to keep only one PR open, because currently the discussion is scattered between two PRs.
Let's hold off on moving forward with this one until we reach a clear consensus on what direction this should be going. Also, it looks like the author of #15400 is still interested in working on their PR.
|
Closing in favour of the original PR #15400 (see my comment there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37953