bpo-34679: Restore instantiation Windows IOCP event loop from non-main thread #15492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
changed the title
aeros
suggested changes
Aug 25, 2019
| thread = threading.Thread(target=func) | ||
| thread.start() | ||
| thread.join() | ||
| self.assertTrue(finished) |
There was a problem hiding this comment.
Good idea with regards to adding tests to ensure that further optimizations/changes don't accidentally recreate the bug.
Misc/NEWS.d/next/Library/2019-08-25-18-07-48.bpo-34679.HECzL7.rst
Outdated
Show resolved
Hide resolved
gvanrossum
approved these changes
Aug 25, 2019
Co-Authored-By: Kyle Stanley <[email protected]>
Co-Authored-By: Kyle Stanley <[email protected]>
|
@gvanrossum @aeros167 thanks the review. |
|
@asvetlov: Please replace |
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-15512 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2019
…n thread (pythonGH-15492) * Restore running proactor event loop from non-main thread Co-Authored-By: Kyle Stanley <[email protected]> (cherry picked from commit 1c06009) Co-authored-by: Andrew Svetlov <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 26, 2019
…n thread (GH-15492) * Restore running proactor event loop from non-main thread Co-Authored-By: Kyle Stanley <[email protected]> (cherry picked from commit 1c06009) Co-authored-by: Andrew Svetlov <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…n thread (python#15492) * Restore running proactor event loop from non-main thread Co-Authored-By: Kyle Stanley <[email protected]>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…n thread (python#15492) * Restore running proactor event loop from non-main thread Co-Authored-By: Kyle Stanley <[email protected]>
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…n thread (python#15492) * Restore running proactor event loop from non-main thread Co-Authored-By: Kyle Stanley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34679