bpo-37199: Fix test failures when IPv6 is unavailable or disabled #14480
Conversation
|
@asvetlov: Please replace |
|
Thanks @ZackerySpytz for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…thonGH-14480) (cherry picked from commit c2cda63) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-14486 is a backport of this pull request to the 3.8 branch. |
…-14480) (cherry picked from commit c2cda63) Co-authored-by: Zackery Spytz <[email protected]>
| @@ -91,6 +91,9 @@ def test_ipaddr_info(self): | |||
| self.assertIsNone( | |||
| base_events._ipaddr_info('1.2.3.4', 1, UNSPEC, 0, 0)) | |||
|
|
|||
| if not support.IPV6_ENABLED: | |||
| return | |||
There was a problem hiding this comment.
I don't like this approach, because it's hard to see that the rest of the test is skipped. Please either split the test function into two or move the rest of the code into the if not supported.IPV6_ENABLED block.
There was a problem hiding this comment.
Okay. I am willing to make such changes, but I would like to hear what @asvetlov thinks.
There was a problem hiding this comment.
@ZackerySpytz please make a PR with changes suggested by @tiran
My first reaction was opening the source code to make sure that the return doesn't make harm.
On the other hand, I've committed the PR as is because you proposed a minimal possible diff.
There was a problem hiding this comment.
Okay. I have created GH-14535.
|
Thanks @ZackerySpytz for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry @ZackerySpytz and @asvetlov, I had trouble checking out the |
https://bugs.python.org/issue37199