Skip to content

bpo-19696: Replace deprecated method in "test_import_pkg.py" #14466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2019

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Jun 29, 2019

Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue.

Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones.

https://bugs.python.org/issue19696

aeros added 2 commits June 29, 2019 11:39
Replaced deprecated method "random.choose" with "random.choice" (https://docs.python.org/3/library/random.html).
This will be my third PR to the cpython repository, forgot to add my name in the previous ones.
blurb-it bot and others added 2 commits June 29, 2019 16:02
When I added my name to the file, I accidentally created a new line at the end. This should fix the commit errors.
@brettcannon
Copy link
Member

Thanks!

swapnilraj added a commit to swapnilraj/cpython that referenced this pull request Jul 3, 2019
@aeros aeros deleted the patch-1 branch July 9, 2019 03:17
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…H-14466)

Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue. 

Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones. 



https://bugs.python.org/issue19696
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…H-14466)

Replacing the deprecated method "random.choose" to "random.choice" was technically not part of the original issue. However, it was discussed in the talk page and involved one of the files being moved. I assumed this was too minor to justify the creation of a separate issue. 

Also, I added my name to the contributors list in Misc/ACKS. This will be my third PR to cpython, forgot to do it in the previous ones. 



https://bugs.python.org/issue19696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants