Skip to content

bpo-37178: Allow a one argument form of math.perm() #13905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2019
Merged

bpo-37178: Allow a one argument form of math.perm() #13905

merged 2 commits into from
Jun 8, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Jun 8, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger closed this Jun 8, 2019
@rhettinger rhettinger reopened this Jun 8, 2019
tim-one
tim-one approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serhiy-storchaka
Copy link
Member

Technically this change looks correct, but I do not imagine why somebody can prefer to write perm(n) instead of factorial(n). This is like using hypot(x) instead of abs(x) or fabs(x).

@rhettinger rhettinger merged commit e119b3d into python:master Jun 8, 2019
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-13919 is a backport of this pull request to the 3.8 branch.

rhettinger added a commit that referenced this pull request Jun 8, 2019
@miss-islington @rhettinger
bpo-37178: Allow a one argument form of math.perm() (GH-13905) (GH-13919
feaceaa 
)

(cherry picked from commit e119b3d)

Co-authored-by: Raymond Hettinger <[email protected]>
@rhettinger rhettinger deleted the math_perm_onearg branch June 8, 2019 16:17
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-37178: Allow a one argument form of math.perm() (pythonGH-13905)
97554e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-one tim-one tim-one approved these changes

@mdickinson mdickinson Awaiting requested review from mdickinson

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhettinger @serhiy-storchaka @miss-islington @bedevere-bot @tim-one @the-knights-who-say-ni