-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-132467: Add test case to check whether GenericAlias instance is not class, update docstring of typing._GenericAlias
#133504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…d to be class, update docstring of typing._GenericAlias
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Co-authored-by: Jelle Zijlstra <[email protected]>
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Description
As discussed in the issue, we can't change behaviour of
inspect.isclass
for GenericAlias instances, so that we need to document that they are not considered to be a class.Summary
typing._GenericAlias
. Added one note, changed format of docstring a bit* edit: I should not have updated typing docs, doc was for typing spec only, not about runtime behaviour. So I updated stdtypes docs.
inspect.isclass
returns False forGenericAlias
instances #132467