Skip to content

gh-46236: Document PyUnicode_BuildEncodingMap #133270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

gh-46236: Document PyUnicode_BuildEncodingMap #133270

merged 2 commits into from
May 9, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 1, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 1, 2025
Closed
33 tasks
@ZeroIntensity ZeroIntensity added docs Documentation in the Doc dir skip news topic-C-API needs backport to 3.13 bugs and security fixes labels May 1, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 1, 2025
vstinner
vstinner reviewed May 2, 2025
View reviewed changes
@StanFromIreland @vstinner
Update Doc/c-api/unicode.rst
000ad3f 
Co-authored-by: Victor Stinner <[email protected]>
@StanFromIreland StanFromIreland requested a review from vstinner May 2, 2025 14:26
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
vstinner
vstinner approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit f34ec09 into python:main May 9, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 9, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
@StanFromIreland @miss-islington
pythongh-46236: Document PyUnicode_BuildEncodingMap (pythonGH-133270)
c5e7460 
(cherry picked from commit f34ec09)

Co-authored-by: Stan Ulbrych <[email protected]>
@miss-islington-app
Copy link

Sorry, @StanFromIreland and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f34ec09ba51070b0693d7ced8e57e77d71beb48d 3.13

@StanFromIreland StanFromIreland deleted the buildencodingmap branch May 9, 2025 15:19
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2025

GH-133769 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025
@StanFromIreland
Copy link
Contributor Author

I can do it if you are busy.

@vstinner
Copy link
Member

vstinner commented May 9, 2025

I can do it if you are busy.

I suppose that you're talking about the 3.13 backport: yes sure, go ahead.

vstinner pushed a commit that referenced this pull request May 9, 2025
@miss-islington @StanFromIreland
[3.14] gh-46236: Document PyUnicode_BuildEncodingMap (GH-133270) (#13…
9ad1516 
…3769)

gh-46236: Document PyUnicode_BuildEncodingMap (GH-133270)
(cherry picked from commit f34ec09)

Co-authored-by: Stan Ulbrych <[email protected]>
@hugovk hugovk removed the needs backport to 3.13 bugs and security fixes label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@vstinner vstinner

Labels
docs Documentation in the Doc dir skip news topic-C-API
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StanFromIreland @vstinner @hugovk @serhiy-storchaka @ZeroIntensity