update comment about LLVM bug relevant for --with-tail-call-interp performance
#132297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
|
Thanks! |
Fidget-Spinner
approved these changes
Apr 9, 2025
|
Thanks for the quick review! I signed the CLA, probably the CI needs to be restarted? IIUC, this also needs a |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the release notes for 3.14, I followed some links and noticed that the bug affecting the performance numbers for
--with-tail-call-interpwas fixed in LLVM v20.1.1 (llvm/llvm-project@0412f70) resp. on main (llvm/llvm-project@dd21aac)This to me seems to be trivial enough to not require an issue, but if preferred, I can open one of course.
📚 Documentation preview 📚: https://cpython-previews--132297.org.readthedocs.build/