gh-127833: lexical analysis: Improve section on Names #131474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland
approved these changes
May 7, 2025
|
I like the re-arrangement and separation of identifier and keyword. |
|
Thanks for the reviews! |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
…-131474) (cherry picked from commit c7364f7) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Blaise Pabon <[email protected]>
|
GH-134423 is a backport of this pull request to the 3.14 branch. |
|
Sorry @encukou, I had trouble completing the backport. |
hugovk
pushed a commit
that referenced
this pull request
May 26, 2025
…) (#134423) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Blaise Pabon <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…-131474) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Blaise Pabon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use consistent terminology: "names" are "identifiers", "keywords", and "soft keywords".
Start with the simple case (ASCII), then get more and more technical.
Define NAME in the formal lexical grammar.
Exclude keywords in the
identifierdefinition.📚 Documentation preview 📚: https://cpython-previews--131474.org.readthedocs.build/