Skip to content

gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos #121979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Jul 18, 2024

Linker on Solaris/Illumos is unhappy when you pass -fstack-protector-strong flag via CFLAGS but not LDFLAGS, resulting in the following failure after #120975:

Undefined			first referenced
 symbol  			    in file
__stack_chk_fail                    Programs/_freeze_module.o
__stack_chk_guard                   Programs/_freeze_module.o
ld: fatal: symbol referencing errors

I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific LDFLAGS append.

@corona10
Copy link
Member

see: #121996 (comment)

@kulikjak kulikjak force-pushed the Solaris-fstack-protector-fix branch from 5673fe7 to cd9638a Compare July 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants