gh-120780: Show attribute name for LOAD_SPECIAL in dis output #120781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Jun 20, 2024
iritkatriel
reviewed
Jun 20, 2024
Lib/dis.py
Outdated
| @@ -609,6 +610,8 @@ def get_argval_argrepr(self, op, arg, offset): | |||
| argrepr = obj.__name__ | |||
| else: | |||
| argrepr = repr(obj) | |||
| elif deop == LOAD_SPECIAL: | |||
| argrepr = get_special_method_names()[arg] | |||
There was a problem hiding this comment.
This creates the list every time. With the intrinsic descs we cache it in opcode.py.
iritkatriel
approved these changes
Jun 20, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.