Skip to content

[3.12] gh-117114: Update availability and source code link in os.path.rst #117756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 11, 2024

I added a link to Lib/genericpath.py in the documentation of os.path (and removed the redundant availability notes) in this pull request: #117115, but this wasn't backported.

Note: the other changes in this pull request are NOT being backported.


📚 Documentation preview 📚: https://cpython-previews--117756.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Apr 11, 2024
@nineteendo nineteendo marked this pull request as ready for review April 11, 2024 15:03
@nineteendo
Copy link
Contributor Author

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

@erlend-aasland
Copy link
Contributor

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

AFAICS, this belongs to gh-117114.

@erlend-aasland erlend-aasland changed the title [3.12] Link to genericpath [3.12] gh-117114: Update availability and source code link in os.path.rst Apr 11, 2024
@erlend-aasland
Copy link
Contributor

Are you sure about those availability adjustments?

@nineteendo
Copy link
Contributor Author

Yeah, when a function is defined in both Lib/ntpath.py & Lib/posixpath.py, it's available on all platforms.

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it: d7538dd.

@nineteendo
Copy link
Contributor Author

@zooba, thoughts?

@nineteendo
Copy link
Contributor Author

@AlexWaygood, do you have an opinion on this?

@zooba
Copy link
Member

zooba commented Apr 15, 2024

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it

That and probably a few were only available on one, and then when we added the other we added to the list rather than removing the list.

This looks good to me.

@zooba zooba merged commit 2dcb267 into python:3.12 Apr 15, 2024
@nineteendo nineteendo deleted the link-to-genericpath branch April 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants