[3.12] gh-116633: Add a note about buggy behavior of csv.QUOTE_NOTNULL and csv.QUOTE_STRINGS #117235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A direct link to the docs preview with this note. |
merwok
reviewed
Mar 26, 2024
Prometheus3375
force-pushed
the
gh-116633
branch
from
9205469 to
eac4fc2
Compare
Prometheus3375
requested review from
sethmlarson,
jaraco,
barneygale,
a team,
corona10,
FFY00,
encukou,
hauntsaninja,
ethanfurman,
gvanrossum,
JelleZijlstra,
AlexWaygood,
terryjreedy,
ericvsmith,
rhettinger,
berkerpeksag,
gpshead,
erlend-aasland,
cjw296,
isidentical,
pablogsal and
lysnikolaou
as code owners
JelleZijlstra
removed request for
corona10,
ethanfurman,
markshannon,
pablogsal,
FFY00,
hauntsaninja,
erlend-aasland,
sethmlarson,
terryjreedy,
lysnikolaou,
ezio-melotti,
brandtbucher,
isidentical,
kumaraditya303 and
AlexWaygood
willingc
approved these changes
Oct 30, 2024
|
@merwok would you please re-review? Thanks. |
merwok
changed the title
csv.QUOTE_NOTNULL and csv.QUOTE_STRINGS in 3.12
merwok
approved these changes
Oct 30, 2024
|
Thanks @merwok for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a note about
csv.QUOTE_NOTNULLandcsv.QUOTE_STRINGSnot affectingcsv.readerin 3.12. This issue is resolved in 3.13, thus, this PR is made only to 3.12 branch.I took my inspiration from the note about bugged dispatching of
**=introduced in 3.8 (docs).csv.QUOTE_NOTNULLandcsv.QUOTE_STRINGS#116633📚 Documentation preview 📚: https://cpython-previews--117235.org.readthedocs.build/