Skip to content

gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag from ctypes documentation #115092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ztane
Copy link
Contributor

@ztane ztane commented Feb 6, 2024

Remove a left-over sentence that refers to an [example that was present in Python 3.10 and was using `Py_OptimizeFlag`](https://docs.python.org/3.10/library/ctypes.html#accessing-values-exported-from-dlls).
@ghost
Copy link

ghost commented Feb 6, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Feb 6, 2024
@ztane ztane changed the title gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag from ctypes documentation Feb 21, 2024
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. @encukou You are more up-to-date on ctypes than me. Would you mind giving this a review and determine if we backport to 3.12.

Thanks @ztane.

@willingc willingc requested a review from encukou February 23, 2024 22:47
@willingc willingc added the needs backport to 3.12 only security fixes label Feb 23, 2024
@encukou
Copy link
Member

encukou commented Feb 26, 2024

This should have been done in #96070, which changes the example so that the paragraph after it doesn't make sense. But, the review missed it...

@encukou encukou merged commit 915d7dd into python:main Feb 26, 2024
@miss-islington-app
Copy link

Thanks @ztane for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2024
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
(cherry picked from commit 915d7dd)

Co-authored-by: Antti Haapala <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2024

GH-115936 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 26, 2024
encukou pushed a commit that referenced this pull request Feb 26, 2024
…izeFlag from ctypes documentation (GH-115092) (GH-115936)

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
(cherry picked from commit 915d7dd)

Co-authored-by: Antti Haapala <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants