Skip to content

Docs: reword sentences about dbm submodule traits #114609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 26, 2024

  • don't repeatedly say that keys and values are coerced into bytes

📚 Documentation preview 📚: https://cpython-previews--114609.org.readthedocs.build/

- don't repeatedly say that keys and values are coerced into bytes
@erlend-aasland
Copy link
Contributor Author

Follow-up to address @serhiy-storchaka's concerns.

@erlend-aasland
Copy link
Contributor Author

The general info is here, @serhiy-storchaka:

Key and values are always stored as :class:`bytes`. This means that when
strings are used they are implicitly converted to the default encoding before
being stored.

@erlend-aasland
Copy link
Contributor Author

Are you ok with this PR, @serhiy-storchaka?

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland erlend-aasland merged commit 81e140d into python:main Feb 14, 2024
@erlend-aasland erlend-aasland deleted the docs/dbm-bytes branch February 14, 2024 15:36
@miss-islington-app

This comment has been minimized.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2024
Don't repeatedly say that keys and values are coerced into bytes.
(cherry picked from commit 81e140d)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 14, 2024

GH-115462 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2024
Don't repeatedly say that keys and values are coerced into bytes.
(cherry picked from commit 81e140d)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 14, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 14, 2024

GH-115463 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 14, 2024
erlend-aasland added a commit that referenced this pull request Feb 14, 2024
…115462)

Don't repeatedly say that keys and values are coerced into bytes.
(cherry picked from commit 81e140d)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Feb 14, 2024
…115463)

Don't repeatedly say that keys and values are coerced into bytes.
(cherry picked from commit 81e140d)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants