Skip to content

Fix typo in collections.abc docs example #113310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix typo in collections.abc docs example #113310

merged 1 commit into from
Dec 20, 2023

Conversation

lbt
Copy link
Contributor

@lbt lbt commented Dec 20, 2023

Calling the instance reference arg for the next method, "next", seems misleading as it would normally just be "self"


📚 Documentation preview 📚: https://cpython-previews--113310.org.readthedocs.build/

Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
@lbt lbt requested a review from rhettinger as a code owner December 20, 2023 09:38
@ghost
Copy link

ghost commented Dec 20, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 20, 2023
@AlexWaygood AlexWaygood changed the title Trivial : Update collections.abc.rst to fix typo in signature Fix typo in collections.abc docs example Dec 20, 2023
@AlexWaygood AlexWaygood merged commit 22b8945 into python:main Dec 20, 2023
@miss-islington-app
Copy link

Thanks @lbt for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2023
Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
(cherry picked from commit 22b8945)

Co-authored-by: David Greaves <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2023

GH-113311 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 20, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2023

GH-113312 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2023
Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
(cherry picked from commit 22b8945)

Co-authored-by: David Greaves <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 20, 2023
AlexWaygood pushed a commit that referenced this pull request Dec 20, 2023
Fix typo in collections.abc docs example (GH-113310)

Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
(cherry picked from commit 22b8945)

Co-authored-by: David Greaves <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Dec 20, 2023
Fix typo in collections.abc docs example (GH-113310)

Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
(cherry picked from commit 22b8945)

Co-authored-by: David Greaves <[email protected]>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Calling the instance reference arg for the __next__ method, "next", seems misleading as it would normally just be "self"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants