gh-113119 fix environment handling in subprocess.Popen when posix_spawn is used #113120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
gpshead
reviewed
Dec 15, 2023
There was a problem hiding this comment.
The code looks good, can you add a NEWS entry (step 8 in https://devguide.python.org/) and mention the os.posix_spawn feature of accepting env=None to mean "use the current process environment" in Doc/whatsnew/3.13.rst?
|
Thanks for the review. I added a NEWS fragment and whatsnew entry as per your suggestion. |
gpshead
approved these changes
Dec 17, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ix_spawn is used (python#113120) * Allow posix_spawn to inherit environment form parent environ variable. With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ix_spawn is used (python#113120) * Allow posix_spawn to inherit environment form parent environ variable. With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113119 .
📚 Documentation preview 📚: https://cpython-previews--113120.org.readthedocs.build/