-
-
Notifications
You must be signed in to change notification settings - Fork 32k
GH-111485: Allow arbitrary annotations on instructions and micro-ops. #111697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-111485: Allow arbitrary annotations on instructions and micro-ops. #111697
Conversation
… declare specializing micro-ops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to add a test for |
Yes, we definitely still want this please.
There were some tests, but this PR removed them. @markshannon is there some reason |
I'll add back the functionality. I assumed it was a feature we added for development and hadn't cleaned up. |
f4b5df7
to
140a681
Compare
Since it is not clear to me if and when |
Great, thank you for doing that. The motivation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Co-authored-by: Guido van Rossum <[email protected]>
This allows us to be explicit about classifications of uops that are currently encoded in the code generator or analysis phase.
As an example, I've added a "specializing" annotation to denote which micro-ops specialize, rather than perform an action.
Using that we can avoid emitting the specialization code in tier 2.
A possible extension is to allow more than one annotation, but this PR only allows one for now.