fix the long64 reader in umarshal.py #107828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
serhiy-storchaka
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Good catch! 🤦♂️
Thank you for your contribution @martindemello.
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @martindemello for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-107849 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 50bbc56) Co-authored-by: Martin DeMello <[email protected]>
|
GH-107850 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 50bbc56) Co-authored-by: Martin DeMello <[email protected]>
|
Note that this code could be simpler and more efficient using |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 50bbc56) Co-authored-by: Martin DeMello <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 11, 2023
Fix the long64 reader in umarshal.py (GH-107828) (cherry picked from commit 50bbc56) Co-authored-by: Martin DeMello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivial fix to a code path that I guess was never really hit.