Skip to content

gh-106084: Remove _PyObject_CallMethod() function #106159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 27, 2023

Remove the following private functions from the public C API:

  • _Py_CheckFunctionResult()
  • _PyObject_CallMethod()
  • _PyObject_CallMethodId()
  • _PyObject_CallMethodIdNoArgs()
  • _PyObject_CallMethodIdObjArgs()
  • _PyObject_CallMethodIdOneArg()
  • _PyObject_MakeTpCall()
  • _PyObject_VectorcallMethodId()
  • _PyStack_AsDict()

Move these functions to the internal C API (pycore_call.h).

No longer export the following functions:

  • _PyObject_Call()
  • _PyObject_CallMethod()
  • _PyObject_CallMethodId()
  • _PyObject_CallMethodIdObjArgs()
  • _PyObject_Call_Prepend()
  • _PyObject_FastCallDictTstate()
  • _PyStack_AsDict()

The following functions are still exported for stdlib shared extensions:

  • _Py_CheckFunctionResult()
  • _PyObject_MakeTpCall()

Mark the following internal functions as extern:

  • _PyStack_UnpackDict()
  • _PyStack_UnpackDict_Free()
  • _PyStack_UnpackDict_FreeNoDecRef()

Remove the following private functions from the public C API:

* _Py_CheckFunctionResult()
* _PyObject_CallMethod()
* _PyObject_CallMethodId()
* _PyObject_CallMethodIdNoArgs()
* _PyObject_CallMethodIdObjArgs()
* _PyObject_CallMethodIdOneArg()
* _PyObject_MakeTpCall()
* _PyObject_VectorcallMethodId()
* _PyStack_AsDict()

Move these functions to the internal C API (pycore_call.h).

No longer export the following functions:

* _PyObject_Call()
* _PyObject_CallMethod()
* _PyObject_CallMethodId()
* _PyObject_CallMethodIdObjArgs()
* _PyObject_Call_Prepend()
* _PyObject_FastCallDictTstate()
* _PyStack_AsDict()

The following functions are still exported for stdlib shared
extensions:

* _Py_CheckFunctionResult()
* _PyObject_MakeTpCall()

Mark the following internal functions as extern:

* _PyStack_UnpackDict()
* _PyStack_UnpackDict_Free()
* _PyStack_UnpackDict_FreeNoDecRef()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants