Skip to content

gh-103880: Fix assertRaises usage in test_genericalias #103916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

gh-103880: Fix assertRaises usage in test_genericalias #103916

merged 1 commit into from
Apr 27, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 27, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
@Fidget-Spinner
Copy link
Member

Thanks. We should backport this to 3.11 right?

@Fidget-Spinner Fidget-Spinner merged commit dff8e5d into python:main Apr 27, 2023
@sobolevn sobolevn added the needs backport to 3.11 only security fixes label Apr 27, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @Fidget-Spinner, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker dff8e5dc8d0758d1f9c55fdef308e44aefebe1a2 3.11

@sobolevn
Copy link
Member Author

Yes!

@sobolevn
Copy link
Member Author

I will do the backport manually.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 27, 2023
@sobolevn
[3.11] pythongh-103880: Fix assertRaises usage in `test_genericalia…
bb8adc7 
…s` (pythonGH-103916)

(cherry picked from commit dff8e5d)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

GH-103917 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 27, 2023
kumaraditya303 pushed a commit that referenced this pull request Apr 27, 2023
@sobolevn
[3.11] gh-103880: Fix assertRaises usage in test_genericalias (GH…
7f70f1c 
…-103916) (#103917)

(cherry picked from commit dff8e5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

@Fidget-Spinner Fidget-Spinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @Fidget-Spinner @miss-islington @bedevere-bot