-
-
Notifications
You must be signed in to change notification settings - Fork 32k
separate format
arg doc for shutil.make_archive
#103829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate format
arg doc for shutil.make_archive
#103829
Conversation
d6780fd
to
b148b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some parameters can be grouped together, for example owner and group. But I agree that the description of the format parameter is long enough and is better in its own paragraph.
LGTM. Thank you for your contribution.
Thanks @michalkaptur for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…pythonGH-103829) (cherry picked from commit 53339a0) Co-authored-by: Michal Kaptur <[email protected]>
GH-114897 is a backport of this pull request to the 3.12 branch. |
…pythonGH-103829) (cherry picked from commit 53339a0) Co-authored-by: Michal Kaptur <[email protected]>
GH-114898 is a backport of this pull request to the 3.11 branch. |
…ragraph (GH-103829) (GH-114898) (cherry picked from commit 53339a0) Co-authored-by: Michal Kaptur <[email protected]>
…ragraph (GH-103829) (GH-114897) (cherry picked from commit 53339a0) Co-authored-by: Michal Kaptur <[email protected]>
format
argument description does not follow the formatting standard of placing each argument in a new paragraph, making it hard to read. Fixed that by prepending newlines to the description.