Skip to content

gh-101947: Remove size check from sqlite3 serialize test #102914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 22, 2023

The size of the returned data is too implementation specific.

The size of the returned data is too implementation specific.
@erlend-aasland
Copy link
Contributor Author

cc. @kulikjak

@erlend-aasland
Copy link
Contributor Author

FYI, checking against SQLITE_DEFAULT_PAGE_SIZE is also incorrect, so let's just remove the check. The rest of the test is more than sufficient as a function test.

@kulikjak
Copy link
Contributor

Thanks! I verified that the test now passes.

I guess that the exact size of dumped data is not that important anyway...

@erlend-aasland erlend-aasland linked an issue Mar 22, 2023 that may be closed by this pull request
@erlend-aasland erlend-aasland merged commit 61405da into python:main Mar 22, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-serialize-test branch March 22, 2023 13:05
@bedevere-bot
Copy link

GH-102915 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2023
…nGH-102914)

The size of the returned data is too implementation specific.
(cherry picked from commit 61405da)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 22, 2023
miss-islington added a commit that referenced this pull request Mar 22, 2023
The size of the returned data is too implementation specific.
(cherry picked from commit 61405da)

Co-authored-by: Erlend E. Aasland <[email protected]>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
…n#102914)

The size of the returned data is too implementation specific.
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…n#102914)

The size of the returned data is too implementation specific.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_sqlite3 failure with SQLite 3.40.1
4 participants