gh-101849: Add upgrade codes for old versions of launcher that ended up with later version numbers #101877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended up with later version numbers
|
@pablogsal I'm sure this will be in before it matters, but because it's an installer fix the easiest way to get it out there is to do our next release. There are a few regressions fixed in the launcher that anyone who upgraded from 3.11.[0/1] won't see unless they figure out to do a clean install. |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-101889 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2023
…ended up with later version numbers (pythonGH-101877) (cherry picked from commit 0c6fe81) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 13, 2023
…up with later version numbers (GH-101877) (cherry picked from commit 0c6fe81) Co-authored-by: Steve Dower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An accidental fix in the release build process corrected the version numbers used for the launcher installer. However, since the incorrect versions are higher and have already been released, we now need to detect them specifically to ensure that upgrades work correctly.
This also applies to 3.10, however, there are no significant fixes to the launcher for 3.10, so the lack of upgrades won't cause any issue there. Any install of 3.11 will upgrade from a 3.10 launcher.