Skip to content

gh-101849: Add upgrade codes for old versions of launcher that ended up with later version numbers #101877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 13, 2023

An accidental fix in the release build process corrected the version numbers used for the launcher installer. However, since the incorrect versions are higher and have already been released, we now need to detect them specifically to ensure that upgrades work correctly.

This also applies to 3.10, however, there are no significant fixes to the launcher for 3.10, so the lack of upgrades won't cause any issue there. Any install of 3.11 will upgrade from a 3.10 launcher.

@zooba
Copy link
Member Author

zooba commented Feb 13, 2023

@pablogsal I'm sure this will be in before it matters, but because it's an installer fix the easiest way to get it out there is to do our next release. There are a few regressions fixed in the launcher that anyone who upgraded from 3.11.[0/1] won't see unless they figure out to do a clean install.

@zooba zooba merged commit 0c6fe81 into python:main Feb 13, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh-101849 branch February 13, 2023 20:33
@bedevere-bot
Copy link

GH-101889 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2023
…ended up with later version numbers (pythonGH-101877)

(cherry picked from commit 0c6fe81)

Co-authored-by: Steve Dower <[email protected]>
miss-islington added a commit that referenced this pull request Feb 13, 2023
…up with later version numbers (GH-101877)

(cherry picked from commit 0c6fe81)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants