Skip to content

gh-100925: List array methods under class in array doc #101239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

theWiseAman
Copy link

@theWiseAman theWiseAman commented Jan 22, 2023

@kumaraditya303 I have implemented the proper layout format for issue #100925. Please review and merge it.

@ghost
Copy link

ghost commented Jan 22, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@gvanrossum
Copy link
Member

Could someone from the doc team take this?

@CAM-Gerlach CAM-Gerlach added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 31, 2023
@CAM-Gerlach CAM-Gerlach changed the title gh-100925: Minor array docs improvement. Fixes and Closes #100925. gh-100925: List array methods under class in array doc Jan 31, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your help, @theWiseAman The issue #100925 is describing is that the class attributes and methods are listed separately, as standalone methods/attributes, and should be moved under the relevant class. However, unfortunately this PR does something entirely different, which is mark each of these attributes as class attributes/methods, which they are not (i.e. that they can be accessed on the class object rather than its instances); see the Python documentation for more details).

I was at first going to describe the actual intended change to you, and then provide a patch you could apply, but since that would take more work on your end and doesn't use anything in this PR/branch, I ended up just submitting a separate PR with that instead, #101485 , which supersedes this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants