Skip to content

Improve comments in itertools uniquification recipes #100631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 31, 2022

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Dec 31, 2022

  • Improve example to show the effect of applying the key-function.
  • Add the alternative non-lazy version for both code paths.

@rhettinger rhettinger changed the title Improve uniquification recipes in the itertools docs Improve comments in itertools uniquification recipes Dec 31, 2022
@rhettinger rhettinger merged commit 4ebaae8 into python:main Dec 31, 2022
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100632 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 31, 2022
@rhettinger rhettinger deleted the uniquification_recipes branch December 31, 2022 02:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2022
(cherry picked from commit 4ebaae8)

Co-authored-by: Raymond Hettinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants