Skip to content

Updating documentation for path lib.Path.rename #98240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mateka opened this issue Oct 13, 2022 · 4 comments
Closed

Updating documentation for path lib.Path.rename #98240

mateka opened this issue Oct 13, 2022 · 4 comments
Labels
docs Documentation in the Doc dir easy topic-pathlib

Comments

@mateka
Copy link
Contributor

mateka commented Oct 13, 2022 •
edited by bedevere-bot
Loading

Would it be possible to update documentation of Path.rename method to mention, that it is equivalent of os.rename? Sometimes it is important, that Posix ensures that renames are atomic on the same filesystem.

Linked PRs
@AA-Turner
Copy link
Member

Please may you open an issue on the https://github.com/python/cpython repository? For a small change, I'd also suggest opening a pull request at the same time. See https://devguide.python.org/getting-started/pull-request-lifecycle/ for a quick guide.

I'm closing this issue on this repo as I can't transfer it to the CPython repo, this does not mean that the note has been rejected.

A

@encukou
Copy link
Member

encukou commented Oct 13, 2022

I can transfer it.

@encukou encukou reopened this Oct 13, 2022
@encukou encukou transferred this issue from python/docs-community Oct 13, 2022
@encukou encukou added docs Documentation in the Doc dir easy labels Oct 13, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 13, 2022
Merged
miss-islington pushed a commit that referenced this issue Oct 28, 2022
@mateka
gh-98240: Updated Path.rename docs, when it is atomic (GH-98245)
0023f51
@hauntsaninja
Copy link
Contributor

Should this be backported?

@mateka
Copy link
Contributor Author

mateka commented Oct 29, 2022

I have not checked the code in other versions. If it is true, it would be nice to have.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 30, 2023
@mateka @miss-islington
pythongh-98240: Updated Path.rename docs, when it is atomic (pythonGH…
743db18 
…-98245)

(cherry picked from commit 0023f51)

Co-authored-by: Mateusz <[email protected]>
This was referenced Jan 30, 2023
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 30, 2023
@mateka @miss-islington
pythongh-98240: Updated Path.rename docs, when it is atomic (pythonGH…
1fe72c4 
…-98245)

(cherry picked from commit 0023f51)

Co-authored-by: Mateusz <[email protected]>
miss-islington added a commit that referenced this issue Jan 30, 2023
@miss-islington @mateka
gh-98240: Updated Path.rename docs, when it is atomic (GH-98245)
3bcb630 
(cherry picked from commit 0023f51)

Co-authored-by: Mateusz <[email protected]>
miss-islington added a commit that referenced this issue Jan 30, 2023
@miss-islington @mateka
gh-98240: Updated Path.rename docs, when it is atomic (GH-98245)
efcab4d 
(cherry picked from commit 0023f51)

Co-authored-by: Mateusz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir easy topic-pathlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@encukou @mateka @AA-Turner @hauntsaninja @AlexWaygood