Python doesn't exit with proper resultcode on SIGINT

[foom]

BPO	1054041
Nosy	@mwhudson, @loewis, @gpshead, @pitrou, @vstinner, @jwilk, @rnk, @akheron, @vadmium, @eryksun
PRs	bpo-1054041: Exit properly after an uncaught ^C. #11862 bpo-1054041: Re-init _Py_UnhandledKeyboardInterrupt before run. #11963 bpo-1054041: Add What's New docs. #11999
Files	issue1054041-sigint-exit-gps01.diff sig.py winsig.bat winsig.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2019-02-16.21:08:03.486>
created_at = <Date 2004-10-25.20:27:22.000>
labels = ['interpreter-core', 'type-feature', '3.8']
title = "Python doesn't exit with proper resultcode on SIGINT"
updated_at = <Date 2019-02-23.18:43:51.714>
user = 'https://bugs.python.org/foom'

bugs.python.org fields:

activity = <Date 2019-02-23.18:43:51.714>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2019-02-16.21:08:03.486>
closer = 'gregory.p.smith'
components = ['Interpreter Core']
creation = <Date 2004-10-25.20:27:22.000>
creator = 'foom'
dependencies = []
files = ['20251', '48138', '48141', '48142']
hgrepos = []
issue_num = 1054041
keywords = ['patch', 'needs review']
message_count = 23.0
messages = ['60590', '60591', '114385', '125287', '125593', '125596', '125605', '125624', '136416', '252910', '335481', '335482', '335485', '335488', '335516', '335517', '335556', '335577', '335721', '335723', '335927', '336024', '336399']
nosy_count = 12.0
nosy_names = ['mwh', 'loewis', 'gregory.p.smith', 'foom', 'pitrou', 'vstinner', 'jwilk', 'rnk', 'petri.lehtinen', 'martin.panter', 'SamB', 'eryksun']
pr_nums = ['11862', '11963', '11999']
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1054041'
versions = ['Python 3.8']

[foom]

If you kill a python process with SIGINT (e.g. control-c), it catches
the signal, and raises a KeyboardInterrupt. If the KeyboardInterrupt
propagates to the top level, python exits. However, it exits with a
result of 1, not a result of SIGINT. This means that if you run
python in a shell script, the script will not properly exit on C-c.

When exiting because of a KeyboardInterrupt, python ought to
reraise the SIGINT, as follows, so that the exit code is correct for
the caller:
signal(SIGINT, SIG_DFL);
kill(getpid(), SIGINT);

See also http://www.cons.org/cracauer/sigint.html for a more
detailed discussion on the topic.

[mwhudson]

Logged In: YES
user_id=6656

Feel like writing a patch?

[BreamoreBoy]

I'll close this in a couple of weeks unless someone wants it kept open.