Skip to content

Increase test coverage for HMAC #132388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Apr 11, 2025 · 0 comments
Closed

Increase test coverage for HMAC #132388

picnixz opened this issue Apr 11, 2025 · 0 comments
Assignees
@picnixz
Labels
extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@picnixz
Copy link
Member

picnixz commented Apr 11, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

After implementing HACL* HMAC in #99108, I've observed that I didn't test all code paths and that some tests I assumed were a bit incorrect (some redundancy was done). This is an issue to track all improvements done to HMAC tests (I'm planning to target an almost 100% coverage), but I'll close it when nothing needs to be done "for now".

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@picnixz picnixz added extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Apr 11, 2025
@picnixz picnixz self-assigned this Apr 11, 2025
@bedevere-app bedevere-app bot mentioned this issue Apr 11, 2025
Merged
picnixz added a commit that referenced this issue Apr 12, 2025
@picnixz
gh-132388: Increase test coverage for HMAC (#132389)
9634085 
- Correctly test missing `digestmod` and `digest` parameters.
- Test when chunks of length > 2048 are passed to `update()`.
- Test one-shot HMAC-BLAKE2.
@picnixz picnixz closed this as completed Apr 12, 2025
@bedevere-app bedevere-app bot mentioned this issue Apr 13, 2025
Merged
picnixz pushed a commit that referenced this issue Apr 13, 2025
@abhi-jha
gh-132388: fix typos in Lib/test/test_hmac.py (#132480)
a1cd4ca 
Fix typos that slipped in GH-132389 (commit 9634085).
@bedevere-app bedevere-app bot mentioned this issue Apr 26, 2025
Merged
picnixz added a commit that referenced this issue Apr 26, 2025
@picnixz
gh-132388: remove outdated TODO comment in test_hmac.py (#133008)
e714ead
@bedevere-app bedevere-app bot mentioned this issue May 15, 2025
Merged
picnixz added a commit that referenced this issue May 16, 2025
@picnixz
gh-132388: test HACL* and OpenSSL hash functions in pure Python HMAC (#…
73d71a4 
…134051)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 16, 2025
@picnixz @miss-islington
pythongh-132388: test HACL* and OpenSSL hash functions in pure Python…
2c0fb54 
… HMAC (pythonGH-134051)

(cherry picked from commit 73d71a4)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue May 16, 2025
Merged
gpshead pushed a commit that referenced this issue May 16, 2025
@miss-islington @picnixz
[3.14] gh-132388: test HACL* and OpenSSL hash functions in pure Pytho…
dda5dc5 
…n HMAC (GH-134051) (#134089)

gh-132388: test HACL* and OpenSSL hash functions in pure Python HMAC (GH-134051)
(cherry picked from commit 73d71a4)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz