-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Compilation of HACL fails under macOS Silicon for version 3.14 #130478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for filing this report.
Can you say why? |
The patch solves the problem by hardcoding |
Does HACL* now compile correctly with the latest main? we improved the build (not for macOS explicitly though) but maybe it solves your issue now? |
|
Ok, I think your patch may be a good thing, but let's test both conditions, namely: - if test "$UNIVERSAL_ARCHS" == "universal2"; then
+ if test ( "$build_cpu" == "aarch64" -a "$build_vendor" == "apple" ) -o "$UNIVERSAL_ARCHS" == "universal2"; then (I don't remember well if my syntax is correct or not but I can test this tomorrow) However, where are the $build_cpu and $build_vendor variables defined? I can't find them in configure.ac |
Uh oh!
There was an error while loading. Please reload this page.
Bug report
Bug description:
Related issues: #123748, #130366, #129043
Problem:
In Python 3.14.0a5, when compiling on macOS Silicon without specifying the
--enable-universalsdk
parameter (as there is no need to compile a universal version for x86_64 & arm64), an error "unknown type name 'Lib_IntVector_Intrinsics_vec256'" occurs.Compilation parameters:
Problem analysis:
The Python team previously released a patch for this issue, but in the
configure
andconfigure.ac
scripts, the patch uses the$UNIVERSAL_ARCHS
parameter for condition checks. This fix does not completely resolve the issue because$UNIVERSAL_ARCHS
depends on the--enable-universalsdk
parameter being passed. Without this parameter, the initial value of$UNIVERSAL_ARCHS
isUNIVERSAL_ARCHS="32-bit"
, leading to the conditionif test "$UNIVERSAL_ARCHS" != "universal2"; then
not being effective.Partial configure log:
Repair solution:
In the
configure
andconfigure.ac
scripts, it is necessary to use other conditions for checks instead of relying on$UNIVERSAL_ARCHS
.Attached is a quick fix patch based on
build_cpu
andbuild_vendor
. However, this is not the most appropriate solution.https://github.com/user-attachments/files/18921691/fixed-hacl-arm64.patch
CPython versions tested on:
3.14
Operating systems tested on:
macOS
Linked PRs
The text was updated successfully, but these errors were encountered: