Py313 REPL crash on malformed `os.environ`

[khk-globus]

Bug description

While researching a personal project bug, I made a typo in the REPL. Obviously, one shouldn't do like the following distilled MRE, but a crash is a crash so reporting it:

$ python3.13
Python 3.13.1 (main, Dec 12 2024, 16:35:44) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.environ = []
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File ".../.local/Python3.13.1/lib/python3.13/_pyrepl/__main__.py", line 6, in <module>
    __pyrepl_interactive_console()
  File ".../.local/Python3.13.1/lib/python3.13/_pyrepl/main.py", line 59, in interactive_console
    run_multiline_interactive_console(console)
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/simple_interact.py", line 151, in run_multiline_interactive_console
    statement = multiline_input(more_lines, ps1, ps2)
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/readline.py", line 389, in multiline_input
    return reader.readline()
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/reader.py", line 795, in readline
    self.prepare()
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/historical_reader.py", line 302, in prepare
    super().prepare()
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/reader.py", line 635, in prepare
    self.console.prepare()
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/unix_console.py", line 349, in prepare
    self.height, self.width = self.getheightwidth()
  File ".../local/Python3.13.1/lib/python3.13/_pyrepl/unix_console.py", line 451, in getheightwidth
    return int(os.environ["LINES"]), int(os.environ["COLUMNS"])
TypeError: list indices must be integers or slices, not str

$ echo $?
1

This is clearly a PEBCAK interaction; the proper way to have cleared the environment would have been .clear() (and as an education point and/or reminder for search engine retrieval or others reading this later, os.environ and os.environb are "special" in that they're assumed to exist and are linked — a change to one affects the other).

But, my late-night typo did produce an interpreter crash, so reporting here.

Note that this does not appear to fail in Python up to v3.12. Python 3.13 is the first to crash this way.

Background

I initially thought it was an IPython bug, and so reported it there. @Carreau rightly course-corrected me, with a suggestion for a possible upstream fix in CPython.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

• gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value #128653
• [3.13] gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value (GH-128653) #129186

[hugovk]

Thanks for the report.

Note that this does not appear to fail in Python up to v3.12. Python 3.13 is the first to crash this way.

It's a problem in the new PyREPL added in 3.13, the old one is okay:

❯ PYTHON_BASIC_REPL=1 python
Python 3.13.1 (v3.13.1:06714517797, Dec  3 2024, 14:00:22) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.environ = []
>>> 

https://docs.python.org/3/whatsnew/3.13.html#a-better-interactive-interpreter

[tomasr8]

Similar thing happens when you do e.g.:

>>> import os
>>> os.environ['LINES'] = ''

[khk-globus]

So, that specific bug is within the new PyREPL. I see that. But Carreau hinted that a number of projects assume os.environ is just there and has a dict-like structure; would there be value in considering some protection around os.environ? Something like (hypothetical):

>>> import os
>>> os.environ = {}
Traceback (most recent call last):
   ...
Exception: environ and environb are protected variables; consider `.clear()`
>>> 

That's more controversial of course, but perhaps not without some merit. A thought.

With that, I'll watch from the sidelines unless otherwise poked. Thanks!

[tomasr8]

I don't think we need to make os.environ protected (that would be a pretty large breaking change), but the new REPL probably shouldn't crash because of it. Perhaps just catching the extra TypeError and ValueError might be sufficient?

[MarcRene71]

This kills wfastcgi.py, too. When you configue a Flaskhandler in an Microsoft IIS, pointing to "E:\Python313\python.exe|D:\www_test\wfastcgi.py" it immediately crashes with the self.getheightwidth() Error.

Using 3.12, the same thing works fine.