Skip to content

Add _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarning #123969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iritkatriel opened this issue Sep 11, 2024 · 0 comments · Fixed by #123972
Closed

Add _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarning #123969

iritkatriel opened this issue Sep 11, 2024 · 0 comments · Fixed by #123972
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

The _PyCompile_Error and _PyCompile_Warn functions take a compiler struct as parameter, just for the filename. In order to be able to use these functions from areas of the codebase where this does not exist, we need versions that take just the filename.

I think they should live in Python/errors.py, with _PyErr_ prefix.

Linked PRs
@iritkatriel iritkatriel self-assigned this Sep 11, 2024
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Sep 11, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Sep 11, 2024
@iritkatriel
pythongh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSynt…
b3deb0f 
…axWarning out of compiler
@iritkatriel iritkatriel mentioned this issue Sep 11, 2024
Merged
iritkatriel added a commit that referenced this issue Sep 16, 2024
@iritkatriel
gh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSyntaxWarn…
aba42c0 
…ing out of compiler (#123972)
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this issue Sep 22, 2024
@iritkatriel @savannahostrowski
pythongh-123969: refactor _PyErr_RaiseSyntaxError and _PyErr_EmitSynt…
66a9161 
…axWarning out of compiler (python#123972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
1 participant
@iritkatriel