-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
CSV reader inconsistent with combination of QUOTE_NONNUMERIC and escapechar #113785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't know which behavior is the expected one? To go with the 1st option (any escapes prevent conversion), a Line 724 in 3efcf66
The 2nd option requires Line 702 in 3efcf66
|
I think why the escape character can be used at first place. QUOTE_NONNUMERIC does not affect escaping. If the character conflicts with one of special characters, it will be escaped, number it or not. If in future we will add support of using comma as decimal separator, there will be larger chance of conflict with field delimiter, so they should be escaped. Also, escapes can be necessary use some weird dialect with So I think that option 2 is more preferable. |
@MKuranowski, do you mind to create a PR? |
…ythonGH-122110) (cherry picked from commit a3327db) Co-authored-by: Mikołaj Kuranowski <[email protected]>
…ythonGH-122110) (cherry picked from commit a3327db) Co-authored-by: Mikołaj Kuranowski <[email protected]>
…GH-122110) (GH-122258) (cherry picked from commit a3327db) Co-authored-by: Mikołaj Kuranowski <[email protected]>
…GH-122110) (GH-122259) (cherry picked from commit a3327db) Co-authored-by: Mikołaj Kuranowski <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
It parses numbers with an escaped character in the middle, it parses numbers starting with a dot, but it does not parse numbers starting with an escaped character. The following variants would be more consistent:
Linked PRs
The text was updated successfully, but these errors were encountered: