Skip to content

Tools/c-analyzer/cpython/_parser.py should be ignored from indentation check in patchcheck #103334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Apr 7, 2023 · 0 comments
Closed

Tools/c-analyzer/cpython/_parser.py should be ignored from indentation check in patchcheck #103334

sobolevn opened this issue Apr 7, 2023 · 0 comments
Assignees
@sobolevn
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 7, 2023 •
edited by bedevere-bot
Loading

Right now if you touch this file, it will fail the CI: https://dev.azure.com/Python/cpython/_build/results?buildId=124277&view=logs&j=256d7e09-002a-52d7-8661-29ee3960640e

with:

Getting the list of files that have been added/changed ... 5 files
Fixing Python file whitespace ... 1 file:
  Tools/c-analyzer/cpython/_parser.py

This happens because this file contains tab separated values that are needed for c-analyzer.

I propose to ignore this file by default in patchcheck, because it is a false-positive.
PR is in the works.

CC @ericsnowcurrently

Linked PRs
@sobolevn sobolevn added the type-bug An unexpected behavior, bug, or error label Apr 7, 2023
@sobolevn sobolevn self-assigned this Apr 7, 2023
@sobolevn sobolevn added the build The build process and cross-build label Apr 7, 2023
@sobolevn sobolevn mentioned this issue Apr 7, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 7, 2023
@sobolevn
pythongh-103334: Ignore Tools/c-analyzer/cpython/_parser.py from `p…
1a1c134 
…atchcheck`
@bedevere-bot bedevere-bot mentioned this issue Apr 7, 2023
Merged
miss-islington pushed a commit that referenced this issue Apr 10, 2023
@sobolevn
gh-103334: Ignore Tools/c-analyzer/cpython/_parser.py from `patchch…
40db5c6 
…eck` (GH-103335)

I've also added a small comment to `Tools/c-analyzer/cpython/_parser.py` to trigger the `patchcheck` CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@sobolevn @warsaw
pythongh-103334: Ignore Tools/c-analyzer/cpython/_parser.py from `p…
436ef64 
…atchcheck` (pythonGH-103335)

I've also added a small comment to `Tools/c-analyzer/cpython/_parser.py` to trigger the `patchcheck` CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently
aisk pushed a commit to aisk/cpython that referenced this issue Apr 18, 2023
@sobolevn @aisk
pythongh-103334: Ignore Tools/c-analyzer/cpython/_parser.py from `p…
13dbd3c 
…atchcheck` (pythonGH-103335)

I've also added a small comment to `Tools/c-analyzer/cpython/_parser.py` to trigger the `patchcheck` CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @erlend-aasland